Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): fix time travel GC bug #20107

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jan 11, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR fixes the time travel GC bug that may incorrectly delete objects still being used.
The bug is more likely to arise in situations of very high I/O latency.
The bug was introduced in version 2.1.0, so version 2.0 is not affected.

cherry pick #20108

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link

graphite-app bot commented Jan 11, 2025

Graphite Automations

"release branch request review" took an action on this PR • (01/11/25)

1 reviewer was added to this PR based on xxchan's automation.

@zwang28 zwang28 force-pushed the wangzheng/release-2.1-fix-gc branch from f0e793b to 0d0631d Compare January 11, 2025 02:30
@zwang28 zwang28 enabled auto-merge January 11, 2025 02:49
@zwang28 zwang28 force-pushed the wangzheng/release-2.1-fix-gc branch from 0d0631d to 0c7146c Compare January 11, 2025 03:30
@zwang28 zwang28 added this pull request to the merge queue Jan 11, 2025
Merged via the queue into release-2.1 with commit 3a33031 Jan 11, 2025
27 of 28 checks passed
@zwang28 zwang28 deleted the wangzheng/release-2.1-fix-gc branch January 11, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants