-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): init compaction group #2248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 771 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
768 | 1 | 2 | 0 |
Click to see the invalid file list
- src/meta/src/hummock/manager/mod.rs
Codecov Report
@@ Coverage Diff @@
## main #2248 +/- ##
==========================================
- Coverage 71.24% 71.18% -0.07%
==========================================
Files 655 660 +5
Lines 83523 83865 +342
==========================================
+ Hits 59507 59696 +189
- Misses 24016 24169 +153
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
adfa51a
to
08cb845
Compare
2635827
to
bce23fb
Compare
0f6c8a7
to
949a98c
Compare
78636e0
to
00c107e
Compare
5545a39
to
f27bbb7
Compare
f27bbb7
to
0699492
Compare
Will split to smaller PRs after #2242 |
What's changed and what's your intention?
This PR initializes compaction group. To be compatible with current code, we temporarily create one default compaction group and use the existent tiered compaction picker for it. All files are added to the default compaction group, so the whole write path remains the same.
Changes
HummockManager::commit_epoch
, instead of previous periodic compaction trigger. The compaction frequency are expected to be very different from before.TODO
HummockManager::report_compact_task
.Checklist
Refer to a related PR or issue link (optional)