feat(source): support source failover & refactor #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2257 +/- ##
==========================================
- Coverage 71.07% 70.98% -0.10%
==========================================
Files 675 676 +1
Lines 84502 84736 +234
==========================================
+ Hits 60061 60150 +89
- Misses 24441 24586 +145
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
neverchanje
reviewed
May 3, 2022
| pub struct ConnectorState { | ||
| pub identifier: Bytes, | ||
| pub start_offset: String, | ||
| pub end_offset: String, | ||
| } | ||
|
|
||
| impl SplitMetaData for ConnectorState { |
There was a problem hiding this comment.
I think ConnectorState is not a SplitMetaData? It's not going to be used by list_splits().
Suggested change
| impl SplitMetaData for ConnectorState { | |
| impl ConnectorState { |
There was a problem hiding this comment.
The contents of the SourceStateHandler store need to implement the trait.
2 tasks
Signed-off-by: tabVersion <[email protected]>
* stage Signed-off-by: tabVersion <[email protected]> * load state before stream begins Signed-off-by: tabVersion <[email protected]> * bring stream chunk and offset to executor Signed-off-by: tabVersion <[email protected]> * modify stream format to either Signed-off-by: tabVersion <[email protected]> * use future::pending instead of dead loop Signed-off-by: tabVersion <[email protected]> * make split_offset_mapping an option Signed-off-by: tabVersion <[email protected]>
tabVersion
changed the title
neverchanje
reviewed
May 6, 2022
Signed-off-by: tabVersion <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 784 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 782 | 1 | 1 | 0 |
Click to see the invalid file list
- src/connector/src/dummy_connector.rs
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
neverchanje
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tabVersion [email protected]
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
support failover.
DummyConnector, it will serve as an idle connector for the executor which is assigned no split.rename SourceSplit -> SplitMetaData:
Checklist
Refer to a related PR or issue link (optional)
#1963