Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): ensure chain index is placed at the same node of upstream #2270

Merged
merged 3 commits into from
May 5, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented May 3, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

After digging into the code a little bit, it seems that the current scheduling algorithm already ensures that chain and upstreams are placed on the same node. Therefore, I added some sanity checks to ensure it will still work in the future.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #2211
close #2151

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2270 (410f9e4) into main (70626c4) will decrease coverage by 0.01%.
The diff coverage is 41.50%.

@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
- Coverage   71.04%   71.03%   -0.02%     
==========================================
  Files         665      665              
  Lines       83670    83705      +35     
==========================================
+ Hits        59447    59462      +15     
- Misses      24223    24243      +20     
Flag Coverage Δ
rust 71.03% <41.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/optimizer/plan_node/stream_index_scan.rs 20.93% <0.00%> (-0.17%) ⬇️
...c/meta/src/stream/fragmenter/rewrite/delta_join.rs 0.00% <0.00%> (ø)
src/meta/src/stream/stream_manager.rs 64.19% <18.75%> (-1.43%) ⬇️
...ntend/src/optimizer/plan_node/stream_table_scan.rs 96.21% <100.00%> (+0.02%) ⬆️
...c/meta/src/stream/fragmenter/graph/stream_graph.rs 65.71% <100.00%> (+0.75%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh requested review from zbzbw and yezizp2012 May 5, 2022 02:17
@skyzh skyzh enabled auto-merge (squash) May 5, 2022 03:43
@skyzh skyzh merged commit bb71a45 into main May 5, 2022
@skyzh skyzh deleted the skyzh/chain-placement branch May 5, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streaming: verify if insert after create index works meta: actor placement rule for chain executor
2 participants