Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(array): implement TrustedLen for ArrayIterator and ArrayImplIterator #2309

Merged
merged 3 commits into from
May 5, 2022

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented May 5, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    implement TrustedLen, added exact size_hint function for ArrayIterator and ArrayImplIterator.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1819

@CLAassistant
Copy link

CLAassistant commented May 5, 2022

CLA assistant check
All committers have signed the CLA.

@TennyZhuang TennyZhuang requested a review from skyzh May 5, 2022 03:10
@TennyZhuang
Copy link
Contributor

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2309 (32844a6) into main (e71d0d2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2309      +/-   ##
==========================================
+ Coverage   71.03%   71.04%   +0.01%     
==========================================
  Files         665      665              
  Lines       83705    83735      +30     
==========================================
+ Hits        59462    59492      +30     
  Misses      24243    24243              
Flag Coverage Δ
rust 71.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/lib.rs 100.00% <ø> (ø)
src/common/src/array/iterator.rs 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@LittleFall LittleFall changed the title WIP: feat(array): implement TrustedLen for *ArrayIter feat(array): implement TrustedLen for *ArrayIter May 5, 2022
@LittleFall LittleFall changed the title feat(array): implement TrustedLen for *ArrayIter feat(array): implement TrustedLen for ArrayIterator and ArrayImplIterator May 5, 2022
@TennyZhuang TennyZhuang merged commit e6b63b2 into risingwavelabs:main May 5, 2022
@TennyZhuang
Copy link
Contributor

CI passed, Thanks!

@LittleFall LittleFall deleted the dev/trustedlen branch May 5, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

array: impl TrustedLen for *ArrayIter
4 participants