Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add nexmark planner test #2321

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented May 5, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

  • Only a few queries can be planned.
  • Some of them failed because of parser error. Flink SQL's syntax is somehow different from Postgres.
  • Window functions are expressed differently in RisingWave. Need rewrite some queries.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from neverchanje May 5, 2022 06:29
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't imagine you completed them so fast!

@skyzh skyzh enabled auto-merge (squash) May 5, 2022 06:35
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2321 (a9b60a6) into main (aaf98ff) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
+ Coverage   71.20%   71.22%   +0.01%     
==========================================
  Files         672      672              
  Lines       84411    84411              
==========================================
+ Hits        60109    60121      +12     
+ Misses      24302    24290      -12     
Flag Coverage Δ
rust 71.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlparser/src/ast/mod.rs 86.98% <0.00%> (+0.23%) ⬆️
src/frontend/src/expr/agg_call.rs 57.69% <0.00%> (+1.28%) ⬆️
src/frontend/src/binder/expr/value.rs 89.71% <0.00%> (+2.80%) ⬆️
src/common/src/types/interval.rs 76.38% <0.00%> (+3.01%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit a308910 into main May 5, 2022
@skyzh skyzh deleted the skyzh/nexmark-planner-test branch May 5, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants