Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard-v2): failed to render because API is changed #2368

Merged
merged 2 commits into from
May 8, 2022

Conversation

cloudcarver
Copy link
Contributor

What's changed and what's your intention?

Fixed parser for two changes in the meta-node API: 1) operatorId is not unique now 2) some properties in operators are renamed (#2255)

This PR just roughly fixed #2359. I will figure out a better solution. (For example, use data definitions in proto)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

@cloudcarver cloudcarver requested a review from skyzh May 8, 2022 06:54
@github-actions github-actions bot added the type/fix Bug fix label May 8, 2022
@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #2368 (d22f0f6) into main (5f3c6d4) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2368      +/-   ##
==========================================
+ Coverage   71.00%   71.09%   +0.08%     
==========================================
  Files         677      678       +1     
  Lines       84757    85038     +281     
==========================================
+ Hits        60181    60456     +275     
- Misses      24576    24582       +6     
Flag Coverage Δ
rust 71.09% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/storage/src/hummock/local_version_manager.rs 89.69% <0.00%> (-0.16%) ⬇️
src/meta/src/hummock/mod.rs 20.18% <0.00%> (ø)
src/stream/src/executor/source.rs 85.66% <0.00%> (ø)
src/storage/src/hummock/sstable/mod.rs 96.87% <0.00%> (ø)
src/storage/src/hummock/compactor_tests.rs 90.26% <0.00%> (ø)
src/meta/src/hummock/compaction_group/mod.rs
...rc/storage/hummock_sdk/src/compaction_group/mod.rs 78.57% <0.00%> (ø)
src/storage/src/hummock/sstable/group_builder.rs 87.09% <0.00%> (ø)
src/meta/src/hummock/compactor_manager.rs 98.22% <0.00%> (+0.01%) ⬆️
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe we can also consider using typescript or partially use typescript in the future 🤣

@skyzh skyzh merged commit 3e8fe1e into main May 8, 2022
@skyzh skyzh deleted the mikecw/dashboard-v2 branch May 8, 2022 07:18
@skyzh
Copy link
Contributor

skyzh commented May 8, 2022

By the way, the dashboard v2 seems quite stable for now. I'm thinking of making it the default choice in the near future...

@cloudcarver
Copy link
Contributor Author

LGTM! Maybe we can also consider using typescript or partially use typescript in the future 🤣

I think so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard v2 failed to parse the data from meta-node
2 participants