fix(streaming): inappropriate serialization for JoinRow
#2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #2398 +/- ##
=======================================
Coverage 71.36% 71.36%
=======================================
Files 680 680
Lines 86089 86088 -1
=======================================
Hits 61439 61439
+ Misses 24650 24649 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
skyzh
reviewed
May 10, 2022
| vec.extend_from_slice(&serializer.into_inner()); | ||
| let mut degree_buf: Vec<u8> = vec![]; | ||
| degree_buf.put_u64_le(self.degree); | ||
| vec.extend_from_slice(°ree_buf); |
There was a problem hiding this comment.
vec.extend_from_slice(&self.degree.to_le_bytes()) should be enough?
There was a problem hiding this comment.
Emmm didnt notice the auto merge
There was a problem hiding this comment.
Ah sorry, will fix those later.
BowenXiao1999
approved these changes
May 10, 2022
| vec.extend_from_slice(&serializer.into_inner()); | ||
| let mut degree_buf: Vec<u8> = vec![]; | ||
| degree_buf.put_u64_le(self.degree); | ||
| vec.extend_from_slice(°ree_buf); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)