-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(batch): use wrapper executor to impl time and i32 generate series #2524
refactor(batch): use wrapper executor to impl time and i32 generate series #2524
Conversation
Signed-off-by: d2lark <[email protected]>
Signed-off-by: d2lark <[email protected]>
Signed-off-by: d2lark <[email protected]>
Signed-off-by: d2lark <[email protected]>
Signed-off-by: d2lark <[email protected]>
ready for review @TennyZhuang @xiangjinwu |
Signed-off-by: d2lark <[email protected]>
Signed-off-by: d2lark <[email protected]>
Signed-off-by: d2lark <[email protected]>
Signed-off-by: d2lark <[email protected]>
Err(ErrorCode::InternalError( | ||
"the parameters of Generate Series Function are incorrect".to_string(), | ||
) | ||
.into()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI PostgreSQL returns 0 rows rather than reporting error when any of the 3 args is null. Can fix it later.
Signed-off-by: d2lark <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2524 +/- ##
==========================================
- Coverage 72.46% 72.39% -0.08%
==========================================
Files 674 675 +1
Lines 87870 87933 +63
==========================================
- Hits 63676 63660 -16
- Misses 24194 24273 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
d2549b4
to
a8551ad
Compare
What's changed and what's your intention?
use wrapper executor to implment time and i32 generate series
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)
close #2443