Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): use wrapper executor to impl time and i32 generate series #2524

Merged
merged 13 commits into from
May 17, 2022

Conversation

D2Lark
Copy link
Contributor

@D2Lark D2Lark commented May 15, 2022

What's changed and what's your intention?

use wrapper executor to implment time and i32 generate series

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #2443

@D2Lark
Copy link
Contributor Author

D2Lark commented May 16, 2022

ready for review @TennyZhuang @xiangjinwu ☺️

src/batch/src/executor2/generate_series.rs Outdated Show resolved Hide resolved
Comment on lines +76 to +79
Err(ErrorCode::InternalError(
"the parameters of Generate Series Function are incorrect".to_string(),
)
.into())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI PostgreSQL returns 0 rows rather than reporting error when any of the 3 args is null. Can fix it later.

Signed-off-by: d2lark <[email protected]>
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #2524 (a8551ad) into main (0e500a7) will decrease coverage by 0.07%.
The diff coverage is 20.62%.

@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
- Coverage   72.46%   72.39%   -0.08%     
==========================================
  Files         674      675       +1     
  Lines       87870    87933      +63     
==========================================
- Hits        63676    63660      -16     
- Misses      24194    24273      +79     
Flag Coverage Δ
rust 72.39% <20.62%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 74.19% <ø> (ø)
src/batch/src/executor2/generate_series.rs 0.00% <0.00%> (-68.86%) ⬇️
src/common/src/types/chrono_wrapper.rs 72.91% <ø> (-1.35%) ⬇️
...rc/frontend/src/binder/relation/generate_series.rs 0.00% <0.00%> (ø)
...d/src/optimizer/plan_node/batch_generate_series.rs 0.00% <0.00%> (ø)
...src/optimizer/plan_node/logical_generate_series.rs 0.00% <0.00%> (ø)
src/frontend/src/planner/relation.rs 75.80% <0.00%> (+7.19%) ⬆️
src/batch/src/executor2/generate_time_series.rs 66.66% <12.50%> (-5.75%) ⬇️
src/batch/src/executor2/generate_i32_series.rs 67.39% <67.39%> (ø)
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xiangjinwu xiangjinwu enabled auto-merge (squash) May 17, 2022 08:06
@xiangjinwu xiangjinwu disabled auto-merge May 17, 2022 08:06
@D2Lark D2Lark force-pushed the refactor_generate_series branch from d2549b4 to a8551ad Compare May 17, 2022 08:11
@xiangjinwu xiangjinwu enabled auto-merge (squash) May 17, 2022 08:17
@xiangjinwu xiangjinwu merged commit 6f76c26 into risingwavelabs:main May 17, 2022
@D2Lark D2Lark deleted the refactor_generate_series branch May 17, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement generate_series(int) in frontend correctly
2 participants