refactor(batch): Remove unnecessary executor #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
May 16, 2022
| create_table.open().await?; | ||
| create_table.next().await?; | ||
| create_table.close().await?; | ||
| // let mut create_table = CreateTableExecutor::new( |
There was a problem hiding this comment.
Just delete them if not used.
There was a problem hiding this comment.
FYI, I fixed this test in this PR: #2550
|
After this PR merged, we've got to restore several test:
|
BugenZhao
approved these changes
May 16, 2022
Comment on lines
87
to
88
| // #[tokio::test] | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Suggested change
| // #[tokio::test] | |
| #[allow(dead_code)] | |
| #[ignore] | |
| #[tokio::test] |
liurenjie1024
commented
May 16, 2022
| }), | ||
| } | ||
| } | ||
| // fn build_create_table_plan(&self) -> PlanFragment { |
There was a problem hiding this comment.
Is this file still usable? @neverchanje
There was a problem hiding this comment.
I've confirmed that this file is completely unused. Pls remove them.
BowenXiao1999
approved these changes
May 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #2548 +/- ##
==========================================
+ Coverage 71.40% 71.48% +0.08%
==========================================
Files 689 685 -4
Lines 88555 88385 -170
==========================================
- Hits 63230 63183 -47
+ Misses 25325 25202 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Remove unnecessary executor after removing legacy java client.
Checklist
Refer to a related PR or issue link (optional)