Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): Remove fuse and trace v1 #2562

Merged
merged 1 commit into from
May 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 0 additions & 133 deletions src/batch/src/executor/fuse.rs

This file was deleted.

18 changes: 2 additions & 16 deletions src/batch/src/executor/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ use risingwave_common::error::Result;
use risingwave_pb::batch_plan::plan_node::NodeBody;
use risingwave_pb::batch_plan::PlanNode;

use self::fuse::FusedExecutor;
use crate::executor::trace::TraceExecutor;
use crate::executor2::executor_wrapper::ExecutorWrapper;
use crate::executor2::{
BoxedExecutor2, BoxedExecutor2Builder, DeleteExecutor2, ExchangeExecutor2, FilterExecutor2,
Expand All @@ -33,10 +31,8 @@ use crate::executor2::{
use crate::task::{BatchEnvironment, TaskId};

pub mod executor2_wrapper;
mod fuse;
#[cfg(test)]
pub mod test_utils;
mod trace;

/// `Executor` is an operator in the query execution.
#[async_trait::async_trait]
Expand All @@ -57,14 +53,6 @@ pub trait Executor: Send {

/// Identity string of the executor
fn identity(&self) -> &str;

/// Turn an executor into a fused executor
fn fuse(self) -> FusedExecutor<Self>
where
Self: Executor + std::marker::Sized,
{
FusedExecutor::new(self)
}
}

pub type BoxedExecutor = Box<dyn Executor>;
Expand Down Expand Up @@ -164,7 +152,7 @@ impl<'a> ExecutorBuilder<'a> {
}

fn try_build(&self) -> Result<BoxedExecutor> {
let real_executor = build_executor! { self,
build_executor! { self,
NodeBody::RowSeqScan => RowSeqScanExecutor2Builder,
NodeBody::Insert => InsertExecutor2,
NodeBody::Delete => DeleteExecutor2,
Expand All @@ -185,9 +173,7 @@ impl<'a> ExecutorBuilder<'a> {
NodeBody::GenerateInt32Series => GenerateSeriesI32Executor2,
NodeBody::GenerateTimeSeries => GenerateSeriesTimestampExecutor2,
NodeBody::HopWindow => HopWindowExecutor2,
}?;
let input_desc = real_executor.identity().to_string();
Ok(Box::new(TraceExecutor::new(real_executor, input_desc)))
}
}

fn try_build2(&self) -> Result<BoxedExecutor2> {
Expand Down
102 changes: 0 additions & 102 deletions src/batch/src/executor/trace.rs

This file was deleted.