Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batch): remove unnecessary compact #2565

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented May 16, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #2565 (eea253c) into main (523b669) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #2565   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files         676      676           
  Lines       87551    87560    +9     
=======================================
+ Hits        62980    62987    +7     
- Misses      24571    24573    +2     
Flag Coverage Δ
rust 71.93% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/task/hash_shuffle_channel.rs 0.00% <0.00%> (ø)
src/common/src/buffer/bitmap.rs 89.62% <100.00%> (+0.21%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor Author

skyzh commented May 16, 2022

Also fixes two bugs:

  • Bitmap's bitand and bitor will produce wrong num_bits.
  • Hash sender didn't take visibility into consideration before. After this, I removed the compact on hash sender.

@skyzh skyzh requested a review from likg227 May 16, 2022 07:45
@skyzh skyzh enabled auto-merge (squash) May 16, 2022 07:49
@skyzh skyzh merged commit cfc4188 into main May 16, 2022
@skyzh skyzh deleted the skyzh/remove-unnecessary-compact branch May 16, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants