Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): ignore stmts START TRANSACTION and ABORT #2607

Merged
merged 9 commits into from
May 19, 2022

Conversation

likzn
Copy link
Contributor

@likzn likzn commented May 17, 2022

What's changed and what's your intention?

As issue #2595 say. We return them directly before the investigation of the behavior of pg .

Main changes:

  1. Support parser to parse ABORT
  2. src/frontend/src/handler/mod.rs#handler will return empty response when meet START TRANSACTION and ABORT

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#2595

src/utils/pgwire/src/pg_response.rs Outdated Show resolved Hide resolved
src/frontend/src/handler/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Thanks for your contribution!

@neverchanje neverchanje enabled auto-merge (squash) May 19, 2022 01:39
@likzn
Copy link
Contributor Author

likzn commented May 19, 2022

@neverchanje I find CI failed again in the same problem.So i update branch, but i find i cannot trigger CI. Maybe need you to trigger.

@neverchanje
Copy link
Contributor

Sure, due to the limitation of our current CI service, I gonna fork your pr to our main branch, pls wait a minute:
https://github.com/singularity-data/risingwave/blob/main/CONTRIBUTING.md#to-check-in-prs-from-forks

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2607 (9c28e45) into main (f0d55a8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
- Coverage   72.17%   72.16%   -0.02%     
==========================================
  Files         678      678              
  Lines       88260    88271      +11     
==========================================
- Hits        63701    63699       -2     
- Misses      24559    24572      +13     
Flag Coverage Δ
rust 72.16% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/mod.rs 46.91% <0.00%> (-5.15%) ⬇️
src/sqlparser/src/ast/mod.rs 88.23% <0.00%> (-0.21%) ⬇️
src/sqlparser/src/parser.rs 92.56% <0.00%> (-0.05%) ⬇️
src/utils/pgwire/src/pg_response.rs 35.08% <ø> (ø)
src/storage/src/object/disk.rs 95.45% <0.00%> (-0.27%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@neverchanje neverchanje merged commit 3191cc9 into risingwavelabs:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants