-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(frontend): ignore stmts START TRANSACTION and ABORT #2607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, Thanks for your contribution!
@neverchanje I find CI failed again in the same problem.So i update branch, but i find i cannot trigger CI. Maybe need you to trigger. |
Sure, due to the limitation of our current CI service, I gonna fork your pr to our main branch, pls wait a minute: |
Codecov Report
@@ Coverage Diff @@
## main #2607 +/- ##
==========================================
- Coverage 72.17% 72.16% -0.02%
==========================================
Files 678 678
Lines 88260 88271 +11
==========================================
- Hits 63701 63699 -2
- Misses 24559 24572 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
What's changed and what's your intention?
As issue #2595 say. We return them directly before the investigation of the behavior of pg .
Main changes:
parser
to parseABORT
src/frontend/src/handler/mod.rs#handler
will return empty response when meetSTART TRANSACTION
andABORT
Checklist
Refer to a related PR or issue link (optional)
#2595