Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(streaming): enable actor metrics in release mode #2612

Merged
merged 2 commits into from
May 18, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented May 18, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

Enable metrics in release mode, so that we can know what's going wrong.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested review from fuyufjh and BugenZhao May 18, 2022 02:09
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh enabled auto-merge (squash) May 18, 2022 02:12
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2612 (c0d4900) into main (93ac770) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
- Coverage   72.35%   72.33%   -0.03%     
==========================================
  Files         678      678              
  Lines       88201    88225      +24     
==========================================
- Hits        63822    63819       -3     
- Misses      24379    24406      +27     
Flag Coverage Δ
rust 72.33% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/debug.rs 0.00% <0.00%> (ø)
src/stream/src/executor/debug/trace.rs 0.00% <0.00%> (ø)
src/meta/src/model/barrier.rs 78.57% <0.00%> (-3.58%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/meta/src/barrier/mod.rs 67.88% <0.00%> (-0.34%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 7e23940 into main May 18, 2022
@skyzh skyzh deleted the skyzh/enable-actor-metrics-release branch May 18, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants