Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch avro to fork #2617

Merged
merged 1 commit into from
May 18, 2022
Merged

chore: switch avro to fork #2617

merged 1 commit into from
May 18, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented May 18, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

Apache avro have docsy, bootstrap, etc. as submodule, which will make cargo build extremely slow. We switched to our own fork and remove the submodules.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from fuyufjh May 18, 2022 03:44
@skyzh
Copy link
Contributor Author

skyzh commented May 18, 2022

image

@skyzh skyzh enabled auto-merge (squash) May 18, 2022 03:45
@skyzh
Copy link
Contributor Author

skyzh commented May 18, 2022

may fix #2615

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2617 (80f725e) into main (7e23940) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2617      +/-   ##
==========================================
- Coverage   72.33%   72.33%   -0.01%     
==========================================
  Files         678      678              
  Lines       88225    88225              
==========================================
- Hits        63821    63819       -2     
- Misses      24404    24406       +2     
Flag Coverage Δ
rust 72.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/model/barrier.rs 78.57% <0.00%> (-3.58%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 0c160b7 into main May 18, 2022
@skyzh skyzh deleted the skyzh/avro-fork branch May 18, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants