Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): use generatic type replace generate_series_wrapper_executor #2624

Merged

Conversation

D2Lark
Copy link
Contributor

@D2Lark D2Lark commented May 18, 2022

Signed-off-by: d2lark [email protected]

use generatic type replace generate_series_wrapper_executor

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2624 (3aa7c80) into main (0c160b7) will increase coverage by 0.04%.
The diff coverage is 82.69%.

@@            Coverage Diff             @@
##             main    #2624      +/-   ##
==========================================
+ Coverage   72.33%   72.38%   +0.04%     
==========================================
  Files         678      676       -2     
  Lines       88225    88187      -38     
==========================================
+ Hits        63820    63834      +14     
+ Misses      24405    24353      -52     
Flag Coverage Δ
rust 72.38% <82.69%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 74.19% <ø> (ø)
src/batch/src/executor2/generate_series.rs 60.56% <82.00%> (+60.56%) ⬆️
src/common/src/types/chrono_wrapper.rs 72.00% <100.00%> (-0.92%) ⬇️
src/meta/src/model/barrier.rs 78.57% <0.00%> (-3.58%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/meta/src/barrier/mod.rs 68.21% <0.00%> (+0.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Handling of special params (negative, zero, null, variable-length month) can be in a followup.

@xiangjinwu xiangjinwu merged commit d6494c7 into risingwavelabs:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants