Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ctl) add args ( epoch , table ) in list-kv #2640

Merged
merged 1 commit into from
May 18, 2022

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented May 18, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

  1. Add args ( epoch , table ) in ctl/list-kv, we can use it to query the "kv" in hummock store.

    cargo run --bin risectl -- hummock list-kv --epoch<epoch> --table-id<tableid>

    We will query the "kv" in all tables , if --table-id is null or u32::MAX. And we will query the "kv" with u64::MAX( epoch ) , if --epoch is null

  2. We will see table_id, executor_id in results.

example

usage:
cargo run --bin risectl -- hummock list-kv --epoch=1 --table-id=180
result with epoch = 1 and table_id = 180;
cargo run --bin risectl -- hummock list-kv
result with epoch = u64::MAX and all_table;
output:
table_id:180 key : b"........." ====> value : b"..........."

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any usage example and output examples?

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2640 (af21bdd) into main (b4ead12) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2640      +/-   ##
==========================================
- Coverage   72.28%   72.19%   -0.09%     
==========================================
  Files         678      678              
  Lines       88087    88232     +145     
==========================================
+ Hits        63671    63698      +27     
- Misses      24416    24534     +118     
Flag Coverage Δ
rust 72.19% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ctl/src/cmd_impl/hummock/list_kv.rs 0.00% <0.00%> (ø)
src/ctl/src/common/hummock_service.rs 0.00% <0.00%> (ø)
src/ctl/src/lib.rs 6.25% <0.00%> (-4.87%) ⬇️
src/frontend/src/planner/statement.rs 85.71% <0.00%> (-14.29%) ⬇️
src/frontend/src/binder/statement.rs 54.16% <0.00%> (-14.26%) ⬇️
src/expr/src/vector_op/arithmetic_op.rs 76.26% <0.00%> (-3.22%) ⬇️
src/common/src/types/decimal.rs 80.10% <0.00%> (-2.16%) ⬇️
src/common/src/types/chrono_wrapper.rs 72.00% <0.00%> (-0.92%) ⬇️
src/expr/src/expr/expr_unary.rs 75.72% <0.00%> (-0.25%) ⬇️
src/source/src/manager.rs 47.84% <0.00%> (ø)
... and 17 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xxhZs
Copy link
Contributor Author

xxhZs commented May 18, 2022

Any usage example and output examples?

yes ,I finished it ;

@xxhZs xxhZs merged commit 1b3a9a9 into main May 18, 2022
@xxhZs xxhZs deleted the xxh/create-tableid-epoch-in-ctl branch May 18, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants