Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some logging on pgwire and frontend #2642

Merged
merged 2 commits into from
May 18, 2022
Merged

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented May 18, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

This PR adds some loggings on pgwire and frontend so that it can help us identify the root cause of message flow failures.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2642 (e2ea068) into main (767e616) will decrease coverage by 0.02%.
The diff coverage is 12.00%.

@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   72.21%   72.19%   -0.03%     
==========================================
  Files         678      678              
  Lines       88204    88235      +31     
==========================================
+ Hits        63698    63701       +3     
- Misses      24506    24534      +28     
Flag Coverage Δ
rust 72.19% <12.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/logging/src/lib.rs 0.74% <0.00%> (-0.03%) ⬇️
src/utils/pgwire/src/error.rs 0.00% <ø> (ø)
src/utils/pgwire/src/pg_message.rs 0.00% <0.00%> (ø)
src/utils/pgwire/src/pg_protocol.rs 0.00% <0.00%> (ø)
src/utils/pgwire/src/pg_server.rs 0.00% <0.00%> (ø)
src/frontend/src/session.rs 51.41% <75.00%> (+0.37%) ⬆️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/meta/src/barrier/mod.rs 67.88% <0.00%> (-0.34%) ⬇️
src/meta/src/model/barrier.rs 82.14% <0.00%> (+3.57%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@neverchanje neverchanje merged commit ba83c10 into main May 18, 2022
@neverchanje neverchanje deleted the wt-test-utils branch May 18, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants