Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): Implementation for bitwise operation #2884
feat(expr): Implementation for bitwise operation #2884
Changes from 51 commits
43baed2
8d81e88
1137e7f
b330586
b1b3095
4a82382
b8893b9
748ae00
00662e1
3fcbe92
93c3b23
a2011f8
3db27fd
eeadf9e
cfd560c
b402de0
d43565b
a7f6405
41b0d0d
87296fd
b59ac4d
3eb7175
90444b8
fab8764
14bb70e
b8e3a13
78a54c3
5398d8a
c66ca60
a3c3cb3
ad7dda7
91095a3
0b1cfb3
ec4c0e0
70a5d8e
b773ad7
0d8e71f
53db214
c87bbe0
7e771f5
4a422c8
1bc00ef
0e68cee
b7f0d46
289d30c
05ba239
541c447
5926d4e
05be5d7
f3b9898
45962dc
a157eb9
6f73499
eb52467
9ba0050
30637e2
481e578
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat it,
cargo fmt --all
seems not work on code in macro.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI
a.checked_shl(b).ok_or_else
Not sure if this looks better or worse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright I change it for mine part.
general_shift(l, r, |a,b| a.checked_shl(b).ok_or_else( || RwError::from(NumericValueOutOfRange)))
. I feel it looks better.Just to point out, the previous writing I was copying from
arithmetic_op.rs
. Should it be changed as well for consistency across similar code?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping them consistent would be better.