Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(risedev): store kafka and frontend config when compose deploy #2988

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 6, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

Store Kafka and frontend info to risingwave deployment directory, so that we don't need to manually copy them to the script.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@skyzh skyzh marked this pull request as ready for review June 6, 2022 02:54
@skyzh skyzh requested review from BugenZhao and hzxa21 June 6, 2022 02:54
@skyzh skyzh enabled auto-merge (squash) June 6, 2022 02:59
@skyzh skyzh merged commit e5ed5da into main Jun 6, 2022
@skyzh skyzh deleted the skyzh/risedev-config-store branch June 6, 2022 03:08
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2988 (6759005) into main (485874d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2988      +/-   ##
==========================================
- Coverage   72.97%   72.97%   -0.01%     
==========================================
  Files         721      721              
  Lines       96472    96478       +6     
==========================================
- Hits        70401    70400       -1     
- Misses      26071    26078       +7     
Flag Coverage Δ
rust 72.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/risedevtool/src/bin/risedev-compose.rs 0.44% <0.00%> (-0.02%) ⬇️
src/meta/src/model/barrier.rs 78.57% <0.00%> (-3.58%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants