feat(relational_iter): add state_table_iter with pk_prefix and pk_bounds #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 824 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 822 | 1 | 1 | 0 |
Click to see the invalid file list
- src/frontend/test_runner/tests/gen/testcases.rs
Codecov Report
@@ Coverage Diff @@
## main #3008 +/- ##
==========================================
+ Coverage 73.26% 73.40% +0.14%
==========================================
Files 731 731
Lines 98441 99012 +571
==========================================
+ Hits 72124 72682 +558
- Misses 26317 26330 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
xxchan
reviewed
Jun 6, 2022
xxchan
reviewed
Jun 6, 2022
…into wcy_prefix_iter
wcy-fdu
changed the title
3 tasks
wcy-fdu
changed the title
xxchan
reviewed
Jun 8, 2022
| let start_key_with_prefix = self.keyspace.prefixed_key(&key_bytes); | ||
| let cell_based_bounds = ( | ||
| Included(start_key_with_prefix.clone()), | ||
| Included(next_key(start_key_with_prefix.as_slice())), |
There was a problem hiding this comment.
Yes, indeed my fault. Thanks for your correcting and will be fixed in later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
This PR adds
with_prefixandwith_pk_boundsforStateTableIter, the former can be used while refactoring join with relational table.For example, a table with pk
(a, b)(1, 1)(1, 2)(2, 1)(2, 2)(3, 1)(3, 2)iter(a = 2) will scan
(2, 1), (2, 2), iter(a > 2) will scan(2, 1), (2, 2), (3, 1), (3, 2).Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
close #2811