fix: the signature unmatch in async trait function

[BowenXiao1999]

What's changed and what's your intention?

When we use state_table.iter() in a async trait function, it shows a confusing compiler error about signature mismatch. I think it's compiler's problem but I do not get too many evidence. I just removed the unnecessary closure mentioned in the error and it seems work.

@wcy-fdu can you please check that it fixs your problem? I have tested it on my version.

The compiler error looks like:

Because the .map looks unnecessary, so I just removed it.

Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

[skyzh]

let mut mem_table_iter = mem_table_iter
             .map(|(k, v)| Ok::<_, StorageError>((k, v)))
             .peekable();

Using the original impl can help implement this with async_stream. As we are not using async_stream for now, I'd be okay with this change.

[BugenZhao]

Should wait for #3057 to be merged first?

[BowenXiao1999]

I also provide a PR if you want to test locally #2999 : 2a7e515

[BugenZhao]

We may remove this line since there's no error to throw for memtable iterator now. :)

[BowenXiao1999]

I think it's seperate problem so I submit another PR. #3071

[BowenXiao1999]

Emmm think for twice and I think you are right.. It should be done in this PR. anyway..

[BowenXiao1999]

Actually previous it also can not be Error. It's always map with Ok.

[BugenZhao]

Previously there’re some decoding stuff in the map body so it can be error. Seems this has changed.😁

[wcy-fdu]

This PR also works in my case!
Good Job!

[codecov]

Codecov Report

Merging #3068 (ad9ec87) into main (f6da1a8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3068      +/-   ##
==========================================
- Coverage   73.52%   73.52%   -0.01%     
==========================================
  Files         732      732              
  Lines       99433    99431       -2     
==========================================
- Hits        73106    73103       -3     
- Misses      26327    26328       +1     

Flag	Coverage Δ
rust	73.52% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/storage/src/table/state_table.rs	87.97% <ø> (-0.16%)	⬇️
src/meta/src/model/barrier.rs	78.57% <0.00%> (-3.58%)	⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more