Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all tracing logs relates to pin/unpin #3151

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Jun 13, 2022

What's changed and what's your intention?

We should consider visualize the info in Grafana/Dashboard to help debug instead of directly tracing it.
Otherwise the log size may be huge.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@BowenXiao1999 BowenXiao1999 requested a review from skyzh June 13, 2022 02:59
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3151 (9d53704) into main (d571760) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3151   +/-   ##
=======================================
  Coverage   73.51%   73.51%           
=======================================
  Files         738      738           
  Lines      101671   101668    -3     
=======================================
+ Hits        74743    74744    +1     
+ Misses      26928    26924    -4     
Flag Coverage Δ
rust 73.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/scheduler/hummock_snapshot_manager.rs 18.42% <ø> (+0.47%) ⬆️
src/meta/src/hummock/hummock_manager.rs 86.95% <ø> (+0.08%) ⬆️
src/meta/src/barrier/mod.rs 69.45% <0.00%> (+0.32%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BowenXiao1999 BowenXiao1999 merged commit 32aaae0 into main Jun 13, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw/chore-remove-logs branch June 13, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants