fix(optimizer): fix logical scan pk derive #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
approved these changes
Jun 13, 2022
| .collect::<Vec<_>>() | ||
| .map(|pk_col| i2o.try_map(*pk_col)) | ||
| .collect::<Option<Vec<_>>>() | ||
| .unwrap_or_default() |
There was a problem hiding this comment.
.expect("pk lost during optimization") instead of returning an empty pk set?
There was a problem hiding this comment.
the batch query does not need the pk... I am thinking if we can move the pk property only in stream plan node.
There was a problem hiding this comment.
.expect("pk lost during optimization")
I will add it as an assert when stream plan node created
Codecov Report
@@ Coverage Diff @@
## main #3171 +/- ##
=======================================
Coverage 73.54% 73.54%
=======================================
Files 739 739
Lines 101804 101804
=======================================
Hits 74873 74873
Misses 26931 26931
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
revert #3119
fix #3086, #3118
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)