Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binder): bind CTE only when schema_name is empty #3173

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

TennyZhuang
Copy link
Contributor

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

See the related issue

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Fixes #3155

@TennyZhuang TennyZhuang changed the title fix(frontend): bind CTE only when schema_name is empty fix(binder): bind CTE only when schema_name is empty Jun 13, 2022
@github-actions github-actions bot added the type/fix Bug fix label Jun 13, 2022
@TennyZhuang TennyZhuang enabled auto-merge (squash) June 13, 2022 09:04
@TennyZhuang TennyZhuang merged commit 5e852a7 into main Jun 13, 2022
@TennyZhuang TennyZhuang deleted the fix/cte-respect-schema branch June 13, 2022 09:13
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3173 (30f53e1) into main (14f995c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3173      +/-   ##
==========================================
- Coverage   73.54%   73.54%   -0.01%     
==========================================
  Files         739      739              
  Lines      101809   101811       +2     
==========================================
  Hits        74880    74880              
- Misses      26929    26931       +2     
Flag Coverage Δ
rust 73.54% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/binder/relation/mod.rs 86.80% <100.00%> (+0.18%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 42.39% <0.00%> (-1.09%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.12% <0.00%> (-0.16%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binder doesn't respect schema_name when meets CTE
2 participants