Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up code for legacy frontend #3181

Merged
merged 1 commit into from
Jun 13, 2022
Merged

chore: clean up code for legacy frontend #3181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/stream/src/from_proto/batch_query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,8 @@ impl ExecutorBuilder for BatchQueryExecutorBuilder {
.collect_vec();

let parallel_unit_id = node.get_parallel_unit_id() as u32;
let hash_filter = if let Some(mapping) = &node.hash_mapping {
generate_hash_filter(mapping, parallel_unit_id)
} else {
// TODO: remove this branch once we deprecate Java frontend.
// manually build bitmap with full of ones
let mut hash_filter_builder = BitmapBuilder::with_capacity(VIRTUAL_NODE_COUNT);
for _ in 0..VIRTUAL_NODE_COUNT {
hash_filter_builder.append(true);
}
hash_filter_builder.finish()
};
let mapping = node.hash_mapping.as_ref().unwrap();
let hash_filter = generate_hash_filter(mapping, parallel_unit_id);

let schema = table.schema().clone();
let executor = BatchQueryExecutor::new(
Expand Down