fix(expr, executor): Remove RowExpression: use eval_row and unwrap_or(false) on Datum, not panic on Null/None
#3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3587 +/- ##
=======================================
Coverage 74.30% 74.31%
=======================================
Files 789 789
Lines 111361 111343 -18
=======================================
- Hits 82746 82739 -7
+ Misses 28615 28604 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
In fact I don’t know where RowExpression is used. |
|
We can remove the RowExpression in HashJoinExecutor and use Expression instead since we have eval_row now |
Can you remove it? |
|
Hmm, ok. I'll do it in this PR. |
jon-chuang
changed the title
RowExpression: use eval_row and unwrap_or(false) on Datum, not panic on Null/NoneRowExpression: use eval_row and unwrap_or(false) on Datum, not panic on Null/None
|
LGTM! |
yuhao-su
approved these changes
Jul 6, 2022
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
…ap_or(false)` on `Datum`, not panic on Null/None (risingwavelabs#3587) * eval_row and unwrap_or(false), not panic * fix * fmt * fmt * fmt * remove `RowExpression` * fmt * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
RowExpression: useeval_rowandunwrap_or(false)onDatum, not panic on Null/NoneChecklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)