Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix regress test input file path #3667

Merged
merged 3 commits into from
Jul 5, 2022
Merged

fix(docs): fix regress test input file path #3667

merged 3 commits into from
Jul 5, 2022

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jul 5, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As per the title.

Checklist

- [ ] I have written necessary rustdoc comments
- [ ] I have added necessary unit tests and integration tests

  • All checks passed in ./risedev check (or alias, ./risedev c)

@github-actions github-actions bot added the type/fix Bug fix label Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #3667 (e794f8e) into main (67dbe53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3667   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files         789      789           
  Lines      111361   111361           
=======================================
  Hits        82745    82745           
  Misses      28616    28616           
Flag Coverage Δ
rust 74.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/expr/utils.rs 98.99% <0.00%> (-0.26%) ⬇️
src/meta/src/manager/id.rs 95.50% <0.00%> (ø)
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mergify mergify bot merged commit d4eba74 into main Jul 5, 2022
@mergify mergify bot deleted the lz/fix branch July 5, 2022 18:14
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* fix(docs): fix regress test input file path

* remove stale comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants