Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce logging in the critical path #3704

Merged
merged 5 commits into from
Jul 7, 2022
Merged

fix: reduce logging in the critical path #3704

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
deaf275
fix: reduce logging in the critical path
neverchanje Jul 7, 2022
e2e2fc7
fix cargo check
neverchanje Jul 7, 2022
1c9f7d5
Merge branch 'main' into wt-log-fix
neverchanje Jul 7, 2022
93be928
Merge branch 'main' of https://github.com/singularity-data/risingwave…
neverchanje Jul 7, 2022
cad79b8
Merge branch 'main' into wt-log-fix
mergify[bot] Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/storage/src/hummock/local_version_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ impl LocalVersionManager {
}

pub async fn sync_shared_buffer_epoch(&self, epoch: HummockEpoch) -> HummockResult<()> {
info!("sync epoch {}", epoch);
tracing::trace!("sync epoch {}", epoch);
let (tx, rx) = oneshot::channel();
self.buffer_tracker
.send_event(SharedBufferEvent::SyncEpoch(epoch, tx));
Expand All @@ -433,17 +433,18 @@ impl LocalVersionManager {
{
Some(task) => task,
None => {
info!("sync epoch {} has no more task to do", epoch);
tracing::trace!("sync epoch {} has no more task to do", epoch);
return Ok(());
}
};

let ret = self
.run_upload_task(order_index, epoch, task_payload, false)
.await;
info!(
tracing::trace!(
"sync epoch {} finished. Task size {}",
epoch, task_write_batch_size
epoch,
task_write_batch_size
);
if let Some(conflict_detector) = self.write_conflict_detector.as_ref() {
conflict_detector.archive_epoch(epoch);
Expand Down