feat(frontend): support acl column in pg_namespace #4326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 979 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 977 | 1 | 1 | 0 |
Click to see the invalid file list
- src/frontend/src/catalog/pg_catalog/mod.rs
There was a problem hiding this comment.
license-eye has totally checked 979 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 977 | 1 | 1 | 0 |
Click to see the invalid file list
- src/frontend/src/catalog/pg_catalog/mod.rs
There was a problem hiding this comment.
license-eye has totally checked 979 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 977 | 1 | 1 | 0 |
Click to see the invalid file list
- src/frontend/src/catalog/pg_catalog/mod.rs
There was a problem hiding this comment.
license-eye has totally checked 979 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 977 | 1 | 1 | 0 |
Click to see the invalid file list
- src/frontend/src/catalog/pg_catalog/mod.rs
yezizp2012
reviewed
Aug 2, 2022
There was a problem hiding this comment.
license-eye has totally checked 979 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 977 | 1 | 1 | 0 |
Click to see the invalid file list
- src/frontend/src/catalog/pg_catalog/mod.rs
yezizp2012
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4326 +/- ##
==========================================
- Coverage 74.37% 74.32% -0.06%
==========================================
Files 845 846 +1
Lines 122898 122993 +95
==========================================
+ Hits 91409 91410 +1
- Misses 31489 31583 +94
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
add superuser acl check
yezizp2012
approved these changes
Aug 2, 2022
yezizp2012
added
the
user-facing-changes
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
* inital * add get_acl_items() * add acl column * fix long line * fmt * fix ut * fix license & e2e test * remove check code * add user_privilege.rs add superuser acl check * fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add acl column in pg_namespace
Checklist
./risedev check(or alias,./risedev c)