Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix manual_compaction for l0 sub_compaction #4334

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Aug 1, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • add pick_tables function
  • fix manual_compaction for l0 sub_compaction

Checklist

  • [ ] I have written necessary rustdoc comments
  • [ ] I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@Li0k Li0k marked this pull request as ready for review August 1, 2022 09:36
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #4334 (8348836) into main (49ef7c9) will increase coverage by 0.00%.
The diff coverage is 87.09%.

@@           Coverage Diff           @@
##             main    #4334   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         846      846           
  Lines      123188   123225   +37     
=======================================
+ Hits        91728    91759   +31     
- Misses      31460    31466    +6     
Flag Coverage Δ
rust 74.46% <87.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/hummock/compaction/manual_compaction_picker.rs 96.11% <87.09%> (-2.67%) ⬇️
src/common/src/types/ordered_float.rs 29.10% <0.00%> (+0.19%) ⬆️
...rc/meta/src/hummock/compaction/overlap_strategy.rs 41.73% <0.00%> (+0.78%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions github-actions bot added the type/fix Bug fix label Aug 1, 2022
Copy link
Contributor

@soundOfDestiny soundOfDestiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks very much!

@mergify mergify bot merged commit 37dcac6 into main Aug 2, 2022
@mergify mergify bot deleted the li0k/fix_manual_l0_sub_compaction branch August 2, 2022 10:30
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…labs#4334)

* fix(storage): fix manual_compaction for l0 sub_compaction

* fix(compaction): fix L0-sub-compacion no need target_input

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants