feat(batch): apply row-based encoding for materialize executor and batch mode #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
reviewed
Aug 1, 2022
| @@ -49,8 +49,8 @@ pub struct RowSeqScanExecutor<S: StateStore> { | |||
| } | |||
|
|
|||
| pub enum ScanType<S: StateStore> { | |||
| TableScan(BatchDedupPkIter<S, CellBasedRowSerde>), | |||
| RangeScan(StorageTableIter<S, CellBasedRowSerde>), | |||
| TableScan(StorageTableIter<S, RowBasedSerde>), | |||
There was a problem hiding this comment.
Do we still need to differentiate TableScan and RangeScan?
There was a problem hiding this comment.
Not sure whether we need to differentiate, if we have row-based dudup pk. cc @BugenZhao
There was a problem hiding this comment.
With dedup fully implemented, they should also use the same iterator. For now I think there's no need to differentiate them.
There was a problem hiding this comment.
Will refactor this part in next PR.
Codecov Report
@@ Coverage Diff @@
## main #4335 +/- ##
==========================================
+ Coverage 74.42% 74.47% +0.04%
==========================================
Files 846 846
Lines 122994 123168 +174
==========================================
+ Hits 91537 91727 +190
+ Misses 31457 31441 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BugenZhao
reviewed
Aug 1, 2022
…into wcy/row_based_batch
wcy-fdu
force-pushed
the
wcy/row_based_batch
branch
from
5415e00 to
77ce7f0
Compare
hzxa21
approved these changes
Aug 2, 2022
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
…tch mode (risingwavelabs#4335) * x * row-based mv and batch * remove redudant code * fmt happy * fmt happy * doc * remove clone * refactor * fix column_mapping * update comments Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Checklist
./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
close #4367