fix(batch): Stop polling after data stream returns None
#4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmatz
approved these changes
Aug 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #4371 +/- ##
==========================================
- Coverage 74.47% 74.46% -0.02%
==========================================
Files 846 846
Lines 123168 123188 +20
==========================================
+ Hits 91726 91727 +1
- Misses 31442 31461 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
liurenjie1024
force-pushed
the
renjie/fix_send_error2
branch
from
dfa532f to
68c8662
Compare
Comment on lines
+329
to
+331
| // This is possible since when we have limit executor in parent | ||
| // stage, it may early stop receiving data from downstream, which | ||
| // leads to close of channel. |
There was a problem hiding this comment.
I doubt whether this statement is still valid. Seems like I can directly unwrap...
There was a problem hiding this comment.
No, it's valid. LimitExecutor or TopNExecutor still may early stop receiver.
| x => { | ||
| return Err(InternalError(format!("Failed to send data: {:?}", x)))?; | ||
| if let Some(data_chunk) = res { | ||
| if let Err(e) = sender.send(Some(data_chunk?)).await { |
There was a problem hiding this comment.
If the chunk is Some, I think unwrap on send error is make sense.
There was a problem hiding this comment.
No, this is possible with LimitExecutor
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
…labs#4371) * fix(batch): Stop polling after data stream returns None * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Task execution should stop polling data stream after returning
None.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
Closes #4132