Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): remove append_chunk in nested loop join and hash join #4381

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

wzzzzd
Copy link
Contributor

@wzzzzd wzzzzd commented Aug 2, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

I defined append_chunk in nested loop join and hash join to append data chunks to the data chunk builder. However, in DataChunkBuilder there is an equivalent method trunc_data_chunk. To reduce code redundancy, all append_chunk should be replaced by trunc_data_chunk.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@wzzzzd wzzzzd added component/batch Batch related related issue. mergify/can-merge labels Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #4381 (b7b863f) into main (7f4b979) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4381   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         846      846           
  Lines      123451   123449    -2     
=======================================
- Hits        91933    91932    -1     
+ Misses      31518    31517    -1     
Flag Coverage Δ
rust 74.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/join/hash_join.rs 94.94% <ø> (-0.01%) ⬇️
src/batch/src/executor/join/nested_loop_join.rs 90.59% <ø> (-0.03%) ⬇️
src/meta/src/manager/id.rs 94.56% <0.00%> (ø)
src/connector/src/source/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 3916c58 into risingwavelabs:main Aug 3, 2022
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…oin (risingwavelabs#4381)

remove append_chunk

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/batch Batch related related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants