-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce an auto-discovery for S3 Bucket files for Filesystem connector #608
Conversation
…ngwave-dev into zhenzhou/s3_reader
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
============================================
- Coverage 71.83% 71.53% -0.30%
Complexity 2682 2682
============================================
Files 883 885 +2
Lines 49754 49953 +199
Branches 1692 1694 +2
============================================
- Hits 35739 35733 -6
- Misses 13211 13416 +205
Partials 804 804
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed and what's your intention?
Part of the basic functionality in S3 Source. This includes automatic discovery of how many files are in the current Bucket based on AWS SQS. The implementation has the following limitations
Checklist
Refer to a related PR or issue link (optional)