Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce an auto-discovery for S3 Bucket files for Filesystem connector #608

Merged
merged 11 commits into from
Mar 1, 2022

Conversation

pangzhenzhou
Copy link
Contributor

@pangzhenzhou pangzhenzhou commented Mar 1, 2022

What's changed and what's your intention?

Part of the basic functionality in S3 Source. This includes automatic discovery of how many files are in the current Bucket based on AWS SQS. The implementation has the following limitations

  1. Only apply only Events are supported. Both - the system will only match CreateObjectXXX Event.
  2. S3 Bucket is one-to-one with AWS SQS.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #608 (04bd0ac) into main (5719e31) will decrease coverage by 0.29%.
The diff coverage is 5.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #608      +/-   ##
============================================
- Coverage     71.83%   71.53%   -0.30%     
  Complexity     2682     2682              
============================================
  Files           883      885       +2     
  Lines         49754    49953     +199     
  Branches       1692     1694       +2     
============================================
- Hits          35739    35733       -6     
- Misses        13211    13416     +205     
  Partials        804      804              
Flag Coverage Δ
java 59.86% <ø> (-0.06%) ⬇️
rust 76.63% <5.39%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/connector/src/filesystem/s3/s3_dir.rs 0.00% <0.00%> (ø)
rust/connector/src/filesystem/file_common.rs 85.71% <91.66%> (+0.09%) ⬆️
rust/meta/src/hummock/compaction.rs 68.21% <0.00%> (-0.67%) ⬇️
...r/rules/logical/subquery/SubQueryDecorrelator.java 0.00% <0.00%> (ø)
...ules/logical/subquery/JoinPushExpressionsRule.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5719e31...04bd0ac. Read the comment docs.

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pangzhenzhou pangzhenzhou merged commit 67bb31e into main Mar 1, 2022
@pangzhenzhou pangzhenzhou deleted the zhenzhou/s3_reader branch March 1, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants