feat(meta): support etcd as MetaStore backend #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TennyZhuang <[email protected]>
TennyZhuang
changed the title
Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
============================================
+ Coverage 71.35% 71.57% +0.22%
Complexity 2706 2706
============================================
Files 895 899 +4
Lines 51277 51778 +501
Branches 1730 1751 +21
============================================
+ Hits 36589 37062 +473
- Misses 13873 13901 +28
Partials 815 815
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: TennyZhuang <[email protected]>
4 tasks
TennyZhuang
commented
Mar 3, 2022
| } else { | ||
| // Slow path | ||
| let _g = self.init_lock.lock().await; | ||
| let revision = self.revision.load(atomic::Ordering::Relaxed); |
There was a problem hiding this comment.
Should here be Acquire? @yuhao-su
Signed-off-by: TennyZhuang <[email protected]>
zwang28
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TennyZhuang [email protected]
What's changed and what's your intention?
We cannot run e2e tests based on etcd backend in the PR, but I prefer to merge it first, and add it to risedev as a optional flag, then debug for it.
Checklist
Refer to a related PR or issue link (optional)