Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compaction): stat sst upload cnt during compaction #699

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Conversation

soundOfDestiny
Copy link
Contributor

What's changed and what's your intention?

stat sst upload cnt during compaction, as wcy needs

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #699 (5a794b5) into main (171c105) will increase coverage by 0.00%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #699   +/-   ##
=========================================
  Coverage     71.77%   71.78%           
  Complexity     2706     2706           
=========================================
  Files           899      899           
  Lines         51737    51745    +8     
  Branches       1751     1751           
=========================================
+ Hits          37135    37143    +8     
  Misses        13787    13787           
  Partials        815      815           
Flag Coverage Δ
java 59.57% <ø> (ø)
rust 77.01% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/server/src/server.rs 0.00% <0.00%> (ø)
rust/meta/src/hummock/integration_tests.rs 100.00% <100.00%> (ø)
rust/storage/src/hummock/compactor.rs 63.01% <100.00%> (+0.77%) ⬆️
rust/storage/src/hummock/shared_buffer.rs 91.56% <100.00%> (+0.01%) ⬆️
rust/storage/src/monitor/state_store_stats.rs 98.33% <100.00%> (+0.02%) ⬆️
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171c105...5a794b5. Read the comment docs.

Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get these metrics in 127.0.0.1:1222

rust/storage/src/hummock/shared_buffer.rs Outdated Show resolved Hide resolved
rust/storage/src/hummock/compactor.rs Outdated Show resolved Hide resolved
@soundOfDestiny
Copy link
Contributor Author

Can you get these metrics in 127.0.0.1:1222

May I have some suggestions on how to get them?

Copy link
Contributor

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants