hummock: add async_checkpoint_enabled in HummockOptions #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
reviewed
Mar 4, 2022
| @@ -92,6 +93,9 @@ pub struct StorageConfig { | |||
|
|
|||
| /// Checksum algorithm (Crc32c, XxHash64). | |||
| pub checksum_algo: String, | |||
|
|
|||
| /// Whether to enable async checkpoint | |||
There was a problem hiding this comment.
You may use #[serde(default = "path")] to specify default config, instead of creating a new global variable every time.
There was a problem hiding this comment.
I don't get it. We already had #[serde(default)] annotation for StorageConfig in ComputeNodeConfig and implemented Default for StorageConfig. Are you suggesting removing all DEFAULT_xxx and hardcoding the values in default()?
There was a problem hiding this comment.
Yes, we should remove the outer default and specify default values internally for StorageConfig. Otherwise there will be problems for our users. If we simply comment one line out in risingwave.toml:
[storage]
sstable_size = 268435456
block_size = 4096
bloom_false_positive = 0.1
data_directory = "hummock_001"
# checksum_algo = "crc32c"The program will simply panic instead of filling crc32c for checksum_algo.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: internal error: parse error missing field `checksum_algo` for key `storage` at line 10 column 1
0: std::backtrace_rs::backtrace::libunwind::trace
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
1: std::backtrace_rs::backtrace::trace_unsynchronized
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
2: std::backtrace::Backtrace::create
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/backtrace.rs:328:13
3: <risingwave_common::error::RwError as core::convert::From<risingwave_common::error::ErrorCode>>::from
at ./rust/common/src/error.rs:117:33
4: risingwave_common::config::ComputeNodeConfig::init::{{closure}}
at ./rust/common/src/config.rs:119:26
5: core::result::Result<T,E>::map_err
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/result.rs:854:27
6: risingwave_common::config::ComputeNodeConfig::init
at ./rust/common/src/config.rs:118:41
7: risingwave_compute::server::load_config
at ./rust/compute/src/server.rs:34:5
8: risingwave_compute::server::compute_node_serve::{{closure}}
at ./rust/compute/src/server.rs:43:18
9: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
10: risingwave_compute::start::{{closure}}
at ./rust/compute/src/lib.rs:60:71
11: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
12: risingwave::main::{{closure}}::{{closure}}
at ./rust/cmd/src/bin/risingwave.rs:40:44
13: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
14: <core::pin::Pin<P> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/future.rs:124:9
15: risingwave::main::{{closure}}
at ./rust/cmd/src/bin/risingwave.rs:87:17
16: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
17: tokio::park::thread::CachedParkThread::block_on::{{closure}}
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/park/thread.rs:263:54
18: tokio::coop::with_budget::{{closure}}
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:102:9
19: std::thread::local::LocalKey<T>::try_with
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/thread/local.rs:442:16
20: std::thread::local::LocalKey<T>::with
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/thread/local.rs:418:9
21: tokio::coop::with_budget
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:95:5
22: tokio::coop::budget
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:72:5
23: tokio::park::thread::CachedParkThread::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/park/thread.rs:263:31
24: tokio::runtime::enter::Enter::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/enter.rs:151:13
25: tokio::runtime::thread_pool::ThreadPool::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/thread_pool/mod.rs:73:9
26: tokio::runtime::Runtime::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/mod.rs:477:43
27: risingwave::main
at ./rust/cmd/src/bin/risingwave.rs:84:5
28: core::ops::function::FnOnce::call_once
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/ops/function.rs:227:5
29: std::sys_common::backtrace::__rust_begin_short_backtrace
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/sys_common/backtrace.rs:122:18
30: std::rt::lang_start::{{closure}}
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/rt.rs:145:18
31: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/ops/function.rs:259:13
32: std::panicking::try::do_call
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:492:40
33: std::panicking::try
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:456:19
34: std::panic::catch_unwind
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panic.rs:137:14
35: std::rt::lang_start_internal::{{closure}}
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/rt.rs:128:48
36: std::panicking::try::do_call
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:492:40
37: std::panicking::try
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:456:19
38: std::panic::catch_unwind
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panic.rs:137:14
39: std::rt::lang_start_internal
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/rt.rs:128:20
40: std::rt::lang_start
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/rt.rs:144:17
41: _main
', compute/src/server.rs:34:42
stack backtrace:
0: rust_begin_unwind
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:584:5
1: core::panicking::panic_fmt
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/panicking.rs:143:14
2: core::result::unwrap_failed
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/result.rs:1784:5
3: core::result::Result<T,E>::unwrap
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/result.rs:1077:23
4: risingwave_compute::server::load_config
at ./rust/compute/src/server.rs:34:5
5: risingwave_compute::server::compute_node_serve::{{closure}}
at ./rust/compute/src/server.rs:43:18
6: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
7: risingwave_compute::start::{{closure}}
at ./rust/compute/src/lib.rs:60:71
8: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
9: risingwave::main::{{closure}}::{{closure}}
at ./rust/cmd/src/bin/risingwave.rs:40:44
10: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
11: <core::pin::Pin<P> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/future.rs:124:9
12: risingwave::main::{{closure}}
at ./rust/cmd/src/bin/risingwave.rs:87:17
13: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
14: tokio::park::thread::CachedParkThread::block_on::{{closure}}
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/park/thread.rs:263:54
15: tokio::coop::with_budget::{{closure}}
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:102:9
16: std::thread::local::LocalKey<T>::try_with
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/thread/local.rs:442:16
17: std::thread::local::LocalKey<T>::with
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/thread/local.rs:418:9
18: tokio::coop::with_budget
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:95:5
19: tokio::coop::budget
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:72:5
20: tokio::park::thread::CachedParkThread::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/park/thread.rs:263:31
21: tokio::runtime::enter::Enter::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/enter.rs:151:13
22: tokio::runtime::thread_pool::ThreadPool::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/thread_pool/mod.rs:73:9
23: tokio::runtime::Runtime::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/mod.rs:477:43
24: risingwave::main
at ./rust/cmd/src/bin/risingwave.rs:84:5
25: core::ops::function::FnOnce::call_once
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Codecov Report
@@ Coverage Diff @@
## main #709 +/- ##
============================================
- Coverage 72.44% 72.44% -0.01%
Complexity 2759 2759
============================================
Files 911 911
Lines 52958 52962 +4
Branches 1783 1783
============================================
Hits 38367 38367
- Misses 13699 13703 +4
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BugenZhao
reviewed
Mar 7, 2022
2 tasks
twocode
approved these changes
Mar 9, 2022
hzxa21
force-pushed
the
patrick/add-async-checkpoint-enabled
branch
from
0a08ca5 to
1abc112
Compare
skyzh
reviewed
Mar 9, 2022
| @@ -92,6 +93,9 @@ pub struct StorageConfig { | |||
|
|
|||
| /// Checksum algorithm (Crc32c, XxHash64). | |||
| pub checksum_algo: String, | |||
|
|
|||
| /// Whether to enable async checkpoint | |||
There was a problem hiding this comment.
Yes, we should remove the outer default and specify default values internally for StorageConfig. Otherwise there will be problems for our users. If we simply comment one line out in risingwave.toml:
[storage]
sstable_size = 268435456
block_size = 4096
bloom_false_positive = 0.1
data_directory = "hummock_001"
# checksum_algo = "crc32c"The program will simply panic instead of filling crc32c for checksum_algo.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: internal error: parse error missing field `checksum_algo` for key `storage` at line 10 column 1
0: std::backtrace_rs::backtrace::libunwind::trace
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
1: std::backtrace_rs::backtrace::trace_unsynchronized
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
2: std::backtrace::Backtrace::create
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/backtrace.rs:328:13
3: <risingwave_common::error::RwError as core::convert::From<risingwave_common::error::ErrorCode>>::from
at ./rust/common/src/error.rs:117:33
4: risingwave_common::config::ComputeNodeConfig::init::{{closure}}
at ./rust/common/src/config.rs:119:26
5: core::result::Result<T,E>::map_err
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/result.rs:854:27
6: risingwave_common::config::ComputeNodeConfig::init
at ./rust/common/src/config.rs:118:41
7: risingwave_compute::server::load_config
at ./rust/compute/src/server.rs:34:5
8: risingwave_compute::server::compute_node_serve::{{closure}}
at ./rust/compute/src/server.rs:43:18
9: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
10: risingwave_compute::start::{{closure}}
at ./rust/compute/src/lib.rs:60:71
11: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
12: risingwave::main::{{closure}}::{{closure}}
at ./rust/cmd/src/bin/risingwave.rs:40:44
13: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
14: <core::pin::Pin<P> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/future.rs:124:9
15: risingwave::main::{{closure}}
at ./rust/cmd/src/bin/risingwave.rs:87:17
16: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
17: tokio::park::thread::CachedParkThread::block_on::{{closure}}
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/park/thread.rs:263:54
18: tokio::coop::with_budget::{{closure}}
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:102:9
19: std::thread::local::LocalKey<T>::try_with
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/thread/local.rs:442:16
20: std::thread::local::LocalKey<T>::with
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/thread/local.rs:418:9
21: tokio::coop::with_budget
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:95:5
22: tokio::coop::budget
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:72:5
23: tokio::park::thread::CachedParkThread::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/park/thread.rs:263:31
24: tokio::runtime::enter::Enter::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/enter.rs:151:13
25: tokio::runtime::thread_pool::ThreadPool::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/thread_pool/mod.rs:73:9
26: tokio::runtime::Runtime::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/mod.rs:477:43
27: risingwave::main
at ./rust/cmd/src/bin/risingwave.rs:84:5
28: core::ops::function::FnOnce::call_once
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/ops/function.rs:227:5
29: std::sys_common::backtrace::__rust_begin_short_backtrace
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/sys_common/backtrace.rs:122:18
30: std::rt::lang_start::{{closure}}
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/rt.rs:145:18
31: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/ops/function.rs:259:13
32: std::panicking::try::do_call
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:492:40
33: std::panicking::try
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:456:19
34: std::panic::catch_unwind
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panic.rs:137:14
35: std::rt::lang_start_internal::{{closure}}
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/rt.rs:128:48
36: std::panicking::try::do_call
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:492:40
37: std::panicking::try
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:456:19
38: std::panic::catch_unwind
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panic.rs:137:14
39: std::rt::lang_start_internal
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/rt.rs:128:20
40: std::rt::lang_start
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/rt.rs:144:17
41: _main
', compute/src/server.rs:34:42
stack backtrace:
0: rust_begin_unwind
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/panicking.rs:584:5
1: core::panicking::panic_fmt
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/panicking.rs:143:14
2: core::result::unwrap_failed
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/result.rs:1784:5
3: core::result::Result<T,E>::unwrap
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/result.rs:1077:23
4: risingwave_compute::server::load_config
at ./rust/compute/src/server.rs:34:5
5: risingwave_compute::server::compute_node_serve::{{closure}}
at ./rust/compute/src/server.rs:43:18
6: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
7: risingwave_compute::start::{{closure}}
at ./rust/compute/src/lib.rs:60:71
8: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
9: risingwave::main::{{closure}}::{{closure}}
at ./rust/cmd/src/bin/risingwave.rs:40:44
10: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
11: <core::pin::Pin<P> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/future.rs:124:9
12: risingwave::main::{{closure}}
at ./rust/cmd/src/bin/risingwave.rs:87:17
13: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/future/mod.rs:91:19
14: tokio::park::thread::CachedParkThread::block_on::{{closure}}
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/park/thread.rs:263:54
15: tokio::coop::with_budget::{{closure}}
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:102:9
16: std::thread::local::LocalKey<T>::try_with
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/thread/local.rs:442:16
17: std::thread::local::LocalKey<T>::with
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/std/src/thread/local.rs:418:9
18: tokio::coop::with_budget
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:95:5
19: tokio::coop::budget
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/coop.rs:72:5
20: tokio::park::thread::CachedParkThread::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/park/thread.rs:263:31
21: tokio::runtime::enter::Enter::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/enter.rs:151:13
22: tokio::runtime::thread_pool::ThreadPool::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/thread_pool/mod.rs:73:9
23: tokio::runtime::Runtime::block_on
at /Users/skyzh/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-4f7dbcce21e258a2/tokio-1.17.0/src/runtime/mod.rs:477:43
24: risingwave::main
at ./rust/cmd/src/bin/risingwave.rs:84:5
25: core::ops::function::FnOnce::call_once
at /rustc/1eb72580d076935a3e590deb6e5813a5aef3eca4/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Add
async_checkpoint_enabledto switch on/off for shared buffer.Checklist
Refer to a related PR or issue link (optional)