feat(planner): integrate with PlanRoot #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
commented
Mar 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #726 +/- ##
============================================
+ Coverage 72.35% 72.42% +0.06%
Complexity 2758 2758
============================================
Files 911 911
Lines 52925 52953 +28
Branches 1783 1783
============================================
+ Hits 38295 38351 +56
+ Misses 13738 13710 -28
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangjinwu
force-pushed
the
rust-frontend-planner-root
branch
from
b2ce791 to
1731f5e
Compare
xiangjinwu
changed the title
neverchanje
reviewed
Mar 9, 2022
rust/frontend/src/optimizer/mod.rs
Outdated
Comment on lines
71
to
81
| let (exprs, expr_aliases) = self | ||
| .out_fields | ||
| .ones() | ||
| .zip_eq(self.schema.fields) | ||
| .map(|(index, field)| { | ||
| ( | ||
| InputRef::new(index, field.data_type).to_expr_impl(), | ||
| Some(field.name), | ||
| ) | ||
| }) | ||
| .unzip(); |
There was a problem hiding this comment.
I think I must have read this code piece somewhere..., Take a look at impl ColPrunable for LogicalFilter {. You can do refactoring in another pr if they are repeated.
liurenjie1024
approved these changes
Mar 9, 2022
BowenXiao1999
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
The planner will return
PlanRootrather thanPlanReffor insert and query, as it is the entry point for the optimization phase. Additionally,PlanRoot::as_subplanwould transform it back in cases where it is actually a subtree of a bigger plan rather than the root.Checklist
Refer to a related PR or issue link (optional)