Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compaction): add more metrics into compaction #771

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Conversation

soundOfDestiny
Copy link
Contributor

@soundOfDestiny soundOfDestiny commented Mar 9, 2022

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #771 (f57bfd7) into main (6bbc0be) will decrease coverage by 0.09%.
The diff coverage is 83.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #771      +/-   ##
============================================
- Coverage     72.43%   72.33%   -0.10%     
  Complexity     2759     2759              
============================================
  Files           911      918       +7     
  Lines         52958    53144     +186     
  Branches       1783     1783              
============================================
+ Hits          38358    38443      +85     
- Misses        13708    13809     +101     
  Partials        892      892              
Flag Coverage Δ
java 61.17% <ø> (ø)
rust 77.03% <83.05%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/hummock/hummock_manager.rs 77.08% <55.00%> (-1.19%) ⬇️
rust/storage/src/hummock/shared_buffer.rs 90.58% <88.88%> (-0.05%) ⬇️
rust/meta/src/hummock/compaction.rs 81.06% <100.00%> (-0.98%) ⬇️
rust/meta/src/hummock/compactor_manager.rs 94.50% <100.00%> (+0.06%) ⬆️
rust/meta/src/hummock/level_handler.rs 100.00% <100.00%> (ø)
rust/meta/src/rpc/metrics.rs 35.29% <100.00%> (+1.96%) ⬆️
rust/storage/src/hummock/compactor.rs 64.73% <100.00%> (+4.09%) ⬆️
rust/frontend/src/binder/bind_context.rs 60.00% <0.00%> (-40.00%) ⬇️
rust/stream/src/executor/test_utils.rs 73.61% <0.00%> (-5.56%) ⬇️
rust/batch/src/executor/row_seq_scan.rs 39.53% <0.00%> (-5.21%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bbc0be...f57bfd7. Read the comment docs.

@soundOfDestiny soundOfDestiny changed the title feat(compaction): stat active sst cnts in each level feat(compaction): add more metrics into compaction Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants