Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compaction): metric by frequence and #sst side, compaction doc #829

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

soundOfDestiny
Copy link
Contributor

@soundOfDestiny soundOfDestiny commented Mar 10, 2022

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #829 (3a89972) into main (28e1e21) will increase coverage by 0.71%.
The diff coverage is 79.48%.

@@             Coverage Diff              @@
##               main     #829      +/-   ##
============================================
+ Coverage     72.22%   72.94%   +0.71%     
  Complexity     2766     2766              
============================================
  Files           923      944      +21     
  Lines         53652    55801    +2149     
  Branches       1787     1787              
============================================
+ Hits          38751    40702    +1951     
- Misses        14011    14209     +198     
  Partials        890      890              
Flag Coverage Δ
java 61.23% <ø> (+<0.01%) ⬆️
rust 77.55% <79.48%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/hummock/hummock_manager.rs 77.08% <72.41%> (-0.42%) ⬇️
rust/meta/src/hummock/compaction.rs 81.56% <100.00%> (+0.49%) ⬆️
rust/meta/src/rpc/metrics.rs 46.34% <100.00%> (+5.80%) ⬆️
rust/storage/src/hummock/compactor.rs 64.11% <100.00%> (ø)
rust/common/src/config.rs 57.62% <0.00%> (-25.30%) ⬇️
rust/frontend/src/planner/select.rs 62.50% <0.00%> (-22.12%) ⬇️
rust/meta/src/manager/notification.rs 68.42% <0.00%> (-14.92%) ⬇️
rust/frontend/src/handler/mod.rs 76.92% <0.00%> (-13.99%) ⬇️
rust/common/src/catalog/column.rs 73.68% <0.00%> (-13.82%) ⬇️
rust/rpc_client/src/compute_client.rs 75.43% <0.00%> (-13.46%) ⬇️
... and 212 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@soundOfDestiny soundOfDestiny changed the title feat(compaction): metric by sst_count together with bytes feat(compaction): metric by frequence and #sst side Mar 11, 2022
@soundOfDestiny soundOfDestiny changed the title feat(compaction): metric by frequence and #sst side feat(compaction): metric by frequence and #sst side, compaction doc Mar 11, 2022
@soundOfDestiny soundOfDestiny requested a review from twocode March 11, 2022 04:00
@wcy-fdu wcy-fdu requested a review from skyzh March 11, 2022 04:10
@fuyufjh
Copy link
Member

fuyufjh commented Mar 16, 2022

Any updates? @wcy-fdu @soundOfDestiny

Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the rest!

@soundOfDestiny soundOfDestiny merged commit f6f4df6 into main Mar 16, 2022
@soundOfDestiny soundOfDestiny deleted the zl_sstcnt branch March 16, 2022 09:02
pangzhenzhou pushed a commit that referenced this pull request Mar 28, 2022
…829)

* feat(compaction): metric by sst_count together with bytes

* feat(compaction): add compact frequence stat for each level

* doc(compaction): add comments for compaction

* refactor(metrics): use counter rather than gauge for inc-only metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants