Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): enable heartbeat detection. #830

Merged
merged 7 commits into from
Mar 11, 2022

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Mar 10, 2022

What's changed and what's your intention?

This PR enables heartbeat detection.

  • Start a loop to delete expired node in ClusterManager in meta node.
  • Start a loop to send heartbeat periodically in both frontend and compute node.

TODO:
#856

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@zwang28 zwang28 force-pushed the wangzheng/feat_enable_heartbeat branch from 2ad5acb to abb90e4 Compare March 10, 2022 11:20
@zwang28 zwang28 force-pushed the wangzheng/feat_enable_heartbeat branch from abb90e4 to 41041e6 Compare March 10, 2022 11:29
# Conflicts:
#	rust/compute/src/server.rs
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #830 (3d1b909) into main (53c479c) will increase coverage by 0.01%.
The diff coverage is 73.36%.

@@             Coverage Diff              @@
##               main     #830      +/-   ##
============================================
+ Coverage     72.18%   72.20%   +0.01%     
  Complexity     2766     2766              
============================================
  Files           930      930              
  Lines         54398    54556     +158     
  Branches       1787     1787              
============================================
+ Hits          39267    39391     +124     
- Misses        14241    14275      +34     
  Partials        890      890              
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.66% <73.36%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/compute/src/lib.rs 0.00% <ø> (ø)
rust/compute/src/server.rs 0.00% <0.00%> (ø)
rust/frontend/src/lib.rs 0.00% <ø> (ø)
rust/meta/src/hummock/mod.rs 61.53% <ø> (ø)
rust/meta/src/lib.rs 0.00% <0.00%> (ø)
rust/meta/src/rpc/server.rs 70.75% <69.56%> (-0.68%) ⬇️
rust/meta/src/cluster/mod.rs 75.38% <71.42%> (-2.50%) ⬇️
rust/meta/src/stream/scheduler.rs 93.15% <83.33%> (-0.97%) ⬇️
rust/meta/src/stream/stream_manager.rs 72.26% <83.33%> (+0.16%) ⬆️
rust/rpc_client/src/meta_client.rs 65.77% <91.66%> (+6.47%) ⬆️
... and 10 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zwang28 zwang28 force-pushed the wangzheng/feat_enable_heartbeat branch from 0d0693c to 7375b4f Compare March 11, 2022 04:00
@zwang28 zwang28 changed the title WIP feat(meta): enable heartbeat detection. feat(meta): enable heartbeat detection. Mar 11, 2022
@zwang28 zwang28 marked this pull request as ready for review March 11, 2022 05:01
@zwang28 zwang28 requested a review from yezizp2012 March 11, 2022 05:01
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 merged commit 50f0a82 into main Mar 11, 2022
@zwang28 zwang28 deleted the wangzheng/feat_enable_heartbeat branch March 11, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants