Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support filter and projection stream serialization #976

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 16, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

  • add a mock to_prost for ExprImpl
  • support serialization of stream filter and projection
  • risedev will warn on low ulimit
  • GitHub action will now use timeout-minutes instead of timeout command for better output. (still testing)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

ref #961

@skyzh skyzh requested review from neverchanje and st1page March 16, 2022 08:10
Signed-off-by: Alex Chi <[email protected]>
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #976 (2a7f549) into main (374aa57) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 2a7f549 differs from pull request most recent head 1cd145a. Consider uploading reports for the commit 1cd145a to get more accurate results

@@             Coverage Diff              @@
##               main     #976      +/-   ##
============================================
- Coverage     71.62%   71.58%   -0.04%     
  Complexity     2766     2766              
============================================
  Files           974      974              
  Lines         57030    57059      +29     
  Branches       1790     1790              
============================================
- Hits          40849    40847       -2     
- Misses        15290    15321      +31     
  Partials        891      891              
Flag Coverage Δ
java 61.03% <ø> (ø)
rust 75.64% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/binder/statement.rs 87.50% <0.00%> (ø)
rust/frontend/src/binder/table_ref.rs 76.00% <0.00%> (ø)
rust/frontend/src/expr/literal.rs 58.33% <ø> (ø)
rust/frontend/src/expr/mod.rs 70.00% <0.00%> (-1.80%) ⬇️
rust/frontend/src/optimizer/plan_node/mod.rs 38.77% <0.00%> (ø)
.../frontend/src/optimizer/plan_node/stream_filter.rs 72.22% <0.00%> (-14.45%) ⬇️
...frontend/src/optimizer/plan_node/stream_project.rs 56.25% <0.00%> (-12.99%) ⬇️
...end/src/optimizer/plan_node/stream_table_source.rs 81.81% <0.00%> (-18.19%) ⬇️
rust/risedevtool/src/bin/risedev-playground.rs 0.00% <0.00%> (ø)
rust/meta/src/hummock/compaction.rs 81.00% <0.00%> (-0.56%) ⬇️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh enabled auto-merge (squash) March 16, 2022 08:38
@skyzh skyzh merged commit 8ee40d8 into main Mar 16, 2022
@skyzh skyzh deleted the skyzh/frontend-prost-stream branch March 16, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants