Updated test #5
Open
Updated test #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add apply_validity and set_validity to mutable utf8 array Co-authored-by: artem.malyshev <[email protected]>
jorgecarleitao
commented
Feb 14, 2023
| data_pagesize_limit: None, | ||
| }; | ||
| if array_len != 1 { | ||
| let array = array.sliced(2, array_len - 2); |
There was a problem hiding this comment.
this was panicking due to array_len < 2.
jorgecarleitao
commented
Feb 14, 2023
| let array = array.sliced(2, array_len - 2); | ||
| let (result, _) = write_and_read(array.clone(), version, compression, encodings)?; | ||
| assert_eq!(array.as_ref(), result.as_ref()); | ||
| // stats change with slicing - ignore |
There was a problem hiding this comment.
ignore stats comparison because stats after slicing change.
jorgecarleitao
commented
Feb 14, 2023
|
|
||
| let row_groups = | ||
| RowGroupIterator::try_new(iter.into_iter(), &schema, options, vec![encodings.clone()])?; | ||
| fn write_and_read( |
There was a problem hiding this comment.
refactored to a function for reuse.
ritchie46
force-pushed
the
test_sliced
branch
from
14b3ed7 to
87f4e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.