Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to GNU Fortran on Windows and/or Linux. #17

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Port to GNU Fortran on Windows and/or Linux. #17

wants to merge 17 commits into from

Conversation

monty241
Copy link

Changes developed by Gerard Cats.

monty241 added 17 commits October 21, 2020 09:18
@monty241
Correct code layout and remove author name (Non-functional change) [ER].
47fbf32
@monty241
Correct code layout and remove author name (Non-functional change) [ER].
cfad9cf
@monty241
Revert "Correct code layout and remove author name (Non-functional ch…
ab494fd 
…ange) [ER]."

This reverts commit cfad9cf.

Revert "Correct code layout and remove author name (Non-functional change) [ER]."

This reverts commit 47fbf32.
@monty241
Merge branch 'master' of github.com:rivm-syso/OPS
18b9afd
@monty241
Layout corrections
b669e57 
Corrections:

1. Replace few remaining author names by 'OPS-Support'.
2. Remove trailing spaces on each line.
3. Remove unused end-of-line comments (multiple spaces followed by line end).
@monty241
Enable compilation on gfortran.
af78646
@monty241
to check
4b8dfa7
@monty241
Merge branch '20201027-cleanup-on-v5' into 20201028-gfortran
f0de650 
# Conflicts:
#	m_ops_emis.f90
#	ops_main.f90
#	ops_read_ctr.f90
@monty241
Revert "to check"
10c41a3 
This reverts commit 4b8dfa7.

It concerns functional bugs, non-porting.
@monty241
Remove trailing spaces.
b4b6bd6
@monty241
Merge branch '20201027-cleanup-on-v5' into 20201028-gfortran
aab5725 
# Conflicts:
#	m_getkey.f90
#	m_ops_building.f90
#	m_ops_emis.f90
#	ops_main.f90
#	ops_read_ctr.f90
@monty241
Remove end-of-line comments.
b17a97f
@monty241
Merge branch 'master' into 20201028-gfortran
f29d551 
# Conflicts:
#	m_getkey.f90
@monty241
Correct direction of record length parameter [PR].
64fbd05
@monty241
Clear screen only when not on GNU.
2875906
@monty241
Correct file loading.
74386f9
@monty241
Subroutines have become modules.
132d7c1
@evert-mouw
Copy link

Ter info, wellicht al bekend: Jeroen Laros heeft ca. een jaar geleden al aanpassingen gedaan om de code goed te laten compileren onder Linux met GNU tools. Ook heeft hij een Makefile erbij geleverd. Hij had dit voor het RIVM gedaan. Het lijkt erop dat zijn aanpassingen niet doorgevoerd zijn de main branch.

https://github.com/jfjlaros/OPS/tree/linux

@monty241
Copy link
Author

Relatie leggen naar deels functioneel vergelijkbare change nav opmerking @evert-mouw: #1

@monty241 monty241 mentioned this pull request Nov 15, 2020
Open
@PrivatePuffin
Copy link

@evert-mouw Ik denk dat we nu wel allemaal kunnen concluderen dat OpenSource en RIVM niet samen gaat.

@evert-mouw
Copy link

@evert-mouw Ik denk dat we nu wel allemaal kunnen concluderen dat OpenSource en RIVM niet samen gaat.

Dat bewust weglaten van een Makefile was wel echt ... nouja. We houden hoop ;-)

PS: ik zit bepaald niet in de buurt, maar we spreken nog wel een keer IRL

@RIVM-OPS
Copy link
Collaborator

First of all, we'd like to apologise for the late reaction. We'll try to reply more quickly to future issues and pull requests.

Thank you for this pull request. The development of OPS takes place on an internal RIVM Gitlab server. Therefore, this pull request cannot be merged directly into this repository. However, useful suggestions will be implemented in future OPS versions. In the following months, we will try to process each pull request manually and we will update this pull request once it has been processed.

For future suggestions for code changes, please contact us by creating an issue or via [email protected] before submitting a pull request.

@RIVM-OPS RIVM-OPS added the enhancement New feature or request label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monty241 @evert-mouw @PrivatePuffin @RIVM-OPS