Logic error in ops_bgcon which does not alter the outcome. #18
Conversation
The GridValue is assigned the average when isCell is false. New code matches the specification: "return grid average if point is outside grid or if value is negative". Generic question: Should GridValue return any value or (even the average of a field as currently) when a value outside the domain is requested? If yes and yes the average, then an alternative might be to for negative value alone and not on whether isCell is true or not.
|
It has been silent around this pull request on this looming bug since last November. Is there anything I can do in terms of explanation, elaboration or code comments to ensure proper progress of the resolution for this bug? |
|
First of all, we'd like to apologise for the late reaction. We'll try to reply more quickly to future issues and pull requests. Thank you for this pull request. The development of OPS takes place on an internal RIVM Gitlab server. Therefore, this pull request cannot be merged directly into this repository. However, useful suggestions will be implemented in future OPS versions. In the following months, we will try to process each pull request manually and we will update this pull request once it has been processed. For future suggestions for code changes, please contact us by creating an issue or via [email protected] before submitting a pull request. |
The GridValue is assigned the average when isCell is false.
New code matches the specification: "return grid average if point is outside grid or if value is negative".
Generic question:
Should GridValue return any value or (even the average of a field as currently) when a value outside the domain is requested? If yes and yes the average, then an alternative might be to for negative value alone and not on whether isCell is true or not.
Changes developed by Gerard Cats.