Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RzOutputMode for rz_core_file_print() (o cmd) #1769

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Sep 29, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

Just use RzOutputMode enum for the printing mode, also renamed the function to reflect it's true essence

Test plan

CI is green

Closing issues

Partially addresses #489 in preparation for #1589

librz/core/cfile.c Outdated Show resolved Hide resolved
librz/core/cfile.c Outdated Show resolved Hide resolved
@XVilka XVilka requested review from ret2libc and wargio October 1, 2021 15:21
@XVilka XVilka force-pushed the asan-core-file-list branch from 9d5d056 to ce0ddf6 Compare October 2, 2021 19:12
Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now!

@XVilka XVilka merged commit e75fbc5 into dev Oct 4, 2021
@XVilka XVilka deleted the asan-core-file-list branch October 4, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants