PE x64 SEH fixes #2310

GustavoLCR · 2022-02-13T05:12:37Z

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
I've added tests that prove my fix is effective or that my feature works (if possible)
I've updated the rizin book with the relevant information (if needed)

Detailed description

Addresses most points of #2247

Fixes missing try/catch in OutputDebugStringA (4539d41)
Fixes Function was modified. Reanalyze? (Y/n) after analysis with analysis.trycatch=true (cb7bb46)
Fixes try/catch control flow analysis (5cc0f18)

Test plan

Tests pass

Closing issues

Maybe #2247

GustavoLCR added 8 commits February 13, 2022 01:39

Fix missing SEH scopes in x64 PE

4539d41

Fix multiple exception scopes in same address not adding flags

11ac4ae

Also add flags for the exception filter if it exists

624347f

Fix assertion in rz_analysis_block_update_hash()

cb7bb46

Add call reference for exception filter

38356b4

Update old block's hash when creating a new block in trycatch analysis

90aecbf

Fix trycatch control flow analysis

5cc0f18

Fix test

4c4e29c

GustavoLCR requested review from ret2libc, wargio, thestr4ng3r, XVilka and kazarmy as code owners February 13, 2022 05:12

github-actions bot added PE RzBin labels Feb 13, 2022

wargio approved these changes Feb 13, 2022

View reviewed changes

XVilka approved these changes Feb 13, 2022

View reviewed changes

XVilka merged commit 5eaea7a into rizinorg:dev Feb 13, 2022

Provide feedback