Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github as symbol server for the tests #2686

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Use github as symbol server for the tests #2686

merged 1 commit into from
Jun 10, 2022

Conversation

wargio
Copy link
Member

@wargio wargio commented Jun 10, 2022 •
edited by XVilka
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

Closes #1981

@wargio wargio enabled auto-merge (squash) June 10, 2022 16:18
@wargio wargio merged commit 4c81b52 into dev Jun 10, 2022
@wargio wargio deleted the use-gh-pdb-server branch June 10, 2022 16:39
XVilka pushed a commit that referenced this pull request Jun 17, 2022
@wargio @XVilka
Use github as symbol server for the tests (#2686)
fc156c6
XVilka pushed a commit that referenced this pull request Jun 17, 2022
@wargio @XVilka
Use github as symbol server for the tests (#2686)
01cac89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
rz-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a dummy PDB symbol server just for CI tests
2 participants
@wargio @XVilka