Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename asm.dwarf to asm.debuginfo #3513

Merged
merged 5 commits into from
May 16, 2023
Merged

Rename asm.dwarf to asm.debuginfo #3513

merged 5 commits into from
May 16, 2023

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented May 15, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

just link #907

librz/core/cconfig.c Outdated Show resolved Hide resolved
librz/core/cconfig.c Outdated Show resolved Hide resolved
librz/core/cconfig.c Outdated Show resolved Hide resolved
librz/core/cconfig.c Outdated Show resolved Hide resolved
librz/core/disasm.c Outdated Show resolved Hide resolved
librz/core/disasm.c Outdated Show resolved Hide resolved
@imbillow
Copy link
Contributor Author

Or maybe we can use RzBitVector to store all the flags?

@XVilka
Copy link
Member

XVilka commented May 15, 2023

@imbillow, why not just structure with bools? This structure should not have too many copies in the memory anyway - it's only used for disassembly.

@wargio
Copy link
Member

wargio commented May 15, 2023

i'm actually very ok with a bitmask

@imbillow
Copy link
Contributor Author

@imbillow, why not just structure with bools? This structure should not have too many copies in the memory anyway - it's only used for disassembly.

I'm just a bit obsessive-compulsive. When I think about how a bool in C takes up 1 byte, yet its information content is only 1 bit.

@XVilka XVilka merged commit 59f32b6 into dev May 16, 2023
@XVilka XVilka deleted the debuginfo branch May 16, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants